-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text-splitters: bug fix for CharacterTextSplitter replacing original separator with regex pattern when merging #23519
Open
wulifu2hao
wants to merge
14
commits into
langchain-ai:master
Choose a base branch
from
wulifu2hao:fix_separators
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+154
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal separator when merging splits
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Jun 26, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
Ɑ: text splitters
Related to text splitters package
🤖:bug
Related to a bug, vulnerability, unexpected error with an existing feature
labels
Jun 26, 2024
@baskaryan pls do help review when you have time , thanks :) |
efriis
previously approved these changes
Sep 19, 2024
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Sep 19, 2024
thoughts on these new tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🤖:bug
Related to a bug, vulnerability, unexpected error with an existing feature
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
partner
size:L
This PR changes 100-499 lines, ignoring generated files.
Ɑ: text splitters
Related to text splitters package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
bug: currently when using CharacterTextSplitter with regex pattern as separator (e.g. "\s") and keep_separator=False to split a text like "Hello world", it will end up with "Hello\sworld" (assume chunk_size=15 so after the splitting it will need to merge it back)
changes:
Issue: #23394
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.